sveneld commented on code in PR #2942:
URL: https://github.com/apache/thrift/pull/2942#discussion_r1518113600
##########
lib/php/lib/Transport/TSocketPool.php:
##########
@@ -24,24 +25,6 @@
use Thrift\Exception\TException;
-/**
- * This library makes use of APCu cache to make hosts as down in a web
- * environment. If you are running from the CLI or on a system without APCu
- * installed, then these null functions will step in and act like cache
- * misses.
- */
-if (!function_exists('apcu_fetch')) {
Review Comment:
move it inside class as private methods. Global redeclare is not very good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
