fishy commented on code in PR #2939:
URL: https://github.com/apache/thrift/pull/2939#discussion_r1525585832
##########
lib/java/src/main/java/org/apache/thrift/ProcessFunction.java:
##########
@@ -8,86 +8,91 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-public abstract class ProcessFunction<I, T extends TBase> {
- private final String methodName;
+public abstract class ProcessFunction<I, T extends TBase, A extends TBase> {
+ private final String methodName;
Review Comment:
I believe this is the commit that breaks spotless check for java in CI (and
thus stops running all cross tests):
https://github.com/apache/thrift/actions/runs/8048152173/job/22320319518
@thomasbruggink can you please run `./gradlew :spotlessApply` and commit the
format changes it made in a new PR? thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@thrift.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
