fishy commented on code in PR #2943:
URL: https://github.com/apache/thrift/pull/2943#discussion_r1523849999
##########
compiler/cpp/src/thrift/generate/t_cl_generator.cc:
##########
@@ -221,11 +221,11 @@ void t_cl_generator::package_def(std::ostream &out) {
}
out << ")";
}
- out << ")" << endl << endl;
+ out << ")\n\n";
Review Comment:
in cases like this, the usage of `endl`/`std::endl` makes it much more
obvious how many lines we are adding while `\n` being part of the longer string
just meshes everything together.
I'd suggest still explicitly adding every `\n` individually, like this:
```suggestion
out << ")" << "\n" << "\n";
```
but I don't feel strongly either way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@thrift.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
