sveneld commented on code in PR #2949:
URL: https://github.com/apache/thrift/pull/2949#discussion_r1529315517
##########
lib/php/lib/Server/TSSLServerSocket.php:
##########
@@ -49,6 +49,10 @@ public function __construct($host = 'localhost', $port =
9090, $context = null)
{
$ssl_host = $this->getSSLHost($host);
parent::__construct($ssl_host, $port);
+ // Initialize a stream context if not provided
+ if ($context === null) {
+ $context = stream_context_create();
Review Comment:
stream_socket_server expects to receive resource instead of null. Perhaps
thats why warning is shutted down by @
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
