CJCombrink commented on code in PR #2943: URL: https://github.com/apache/thrift/pull/2943#discussion_r1561366234
########## compiler/cpp/src/thrift/generate/t_dart_generator.cc: ########## @@ -37,8 +37,7 @@ using std::string; using std::stringstream; using std::vector; -static const string endl = "\n"; // avoid ostream << std::endl flushes -static const string endl2 = "\n\n"; +static const string br = "\n"; // Line break Review Comment: The rationale here was that at some places there are `"literal" + endl` and at the time I thought it good to keep the `endl` as a string but rename to steer away from `endl` usage. But the correct solution would be not to do addition on literals but instead strings, I am fixing this with the next commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@thrift.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
