Jens-G commented on code in PR #2943: URL: https://github.com/apache/thrift/pull/2943#discussion_r1564948108
########## compiler/cpp/src/thrift/generate/t_json_generator.cc: ########## @@ -537,7 +535,7 @@ void t_json_generator::write_const_value(t_const_value* value, bool should_force } string t_json_generator::json_str(const string& str) { - return quot + escape_json_string(str) + quot; + return string("\"") + escape_json_string(str) + string("\n"); } Review Comment: Typo? quot should be `string("\"")` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@thrift.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org