cfriedt commented on PR #2747: URL: https://github.com/apache/thrift/pull/2747#issuecomment-2212051152
Sure - thanks for the feedback. There is one other change that I would need to do to upgrade the thrift version used in Zephyr after this. That is, namely, to redo the change where I added an alternative to some boost function (it's been so long I'm having a hard time remembering which). And after that, I was thinking it would be interesting to try and coalesce fbthrift here too, because the newer compiler apparently generates really efficient c++ code with coroutines. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@thrift.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org