emmenlau commented on PR #2747: URL: https://github.com/apache/thrift/pull/2747#issuecomment-2226889503
> Please let me know if there are any additional changes needed I would be so bold to say that your change can not create build errors. Still, I briefly checked the CI, and at least some of the build errors are unrelated. For example the MSVC build was fine except for a python-test failling. Looks good to me, can be merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@thrift.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
