fishy commented on PR #3057: URL: https://github.com/apache/thrift/pull/3057#issuecomment-2442609972
The current state looks good to me, but I'm tagging @dcelasun, @jpkrohling, @yurishkuro who are involved in the discussion and review of the original issue of https://issues.apache.org/jira/browse/THRIFT-5828 and https://github.com/apache/thrift/pull/2292 to take a look. My one (minor) concern is the hardcoded 10MiB limit. For malformed size > 10MiB we are falling back to the current approach which protects against over allocation, but if we have a malformed size that's < 10MiB but close, we are still doing the allocation up front. Does anyone use thrift go in a tight environment that will be a problem? I don't know. And if we do think that's a problem, what should we do to make it configurable? Add it as a new API to TConfiguration? or maybe make it something like "always 1/10 of [`MaxMessageSize` configured via `TConfiguration`](https://pkg.go.dev/github.com/apache/thrift/lib/go/thrift#TConfiguration.MaxMessageSize)"? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@thrift.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
