leitzler commented on PR #3057: URL: https://github.com/apache/thrift/pull/3057#issuecomment-2442804621
Thanks for investigating. I agree, in the THRIFT-5828 I wrote: > Ideally we would use TConfiguration that was added after PR2292 (in [PR #2296](https://github.com/apache/thrift/pull/2296)), there is already a default max message size at 100MB for example. The max message size is already checked before reading so ReadBinary could be changed back to always allocating the full size. But to be more specific I'd prefer option 1 over the others. Reason being that the relation to `MaxMessageSize` looks arbitrary to me (apart from the fact that `MaxMessageSize` will block it first if that value is lower). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@thrift.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
