CJCombrink commented on PR #3144:
URL: https://github.com/apache/thrift/pull/3144#issuecomment-2901564894

   @EnigmaTriton 
   
   > same language on both client and server side (I’m guessing so)
   
   This was my starting point but since I have to integrate my server (c++) 
with a Java client I tested and found the _issue_. Same language client <-> 
server all seems fine, probably because implementation bias where the same 
mistake is made both sides presents as working code. 
   
   > Wireshark should display the data 
   
   I have checked with Wireshark and this is what I see for the C++ Server and 
the .Net Client:
   
![image](https://github.com/user-attachments/assets/70076aa6-4944-42f6-a91b-6b430412906f)
   
   And for C++ server and Java Client:
   
![image](https://github.com/user-attachments/assets/7706c721-b380-4ecc-ac9a-99b87e47297f)
   
   The .Net client sends the data as expected
   The Java client sends data not as expected: The bit-shifting 
[here](https://github.com/apache/thrift/blob/master/lib/java/src/main/java/org/apache/thrift/protocol/TBinaryProtocol.java#L223)
 is breaking my brain bit it does appear to match what I see _on the wire_...
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@thrift.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to