CJCombrink commented on PR #3144: URL: https://github.com/apache/thrift/pull/3144#issuecomment-2938667632
> but almost all languages, even the ones we don't currently run ci, have crossrunner setup there, and you can just use crossrunner locally to run the crosstests between them. Yes I am aware of this, my observation is that these tests does run compatibility tests, but not correctness tests. I am lead to believe this since this incorrectness is not failing the tests For example, when running the cross test with java server and cpp client (locally, on this branch) ``` > python3 test/test.py --skip-known-failures --server java --client cpp ``` Then looking at the following test result: | Server | Client | Protocol | Transport | Result | Expected | | --------- | --- | --- | --- | --- | -- | | java | cpp | binary | buffered-ip | success(0) | yes | And in the logs for "Server": (`java-cpp_binary_buffered-ip_server.log`) ``` ... TServerEventHandler.processContext - connection #1 is ready to process next request testUuid(8899aabb-ccdd-eeff-0011-223344556677) ... ``` The logs for "Client": (`java-cpp_binary_buffered-ip_client.log`) ``` testUuid(00112233-4455-6677-8899-aabbccddeeff) = (00112233-4455-6677-8899-aabbccddeeff) ``` Ultimately the test should fail, or an alternative test or method should be introduced to try and catch this. _I will see if I can't start the process to submit a fix for the Java_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@thrift.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
