Jens-G commented on PR #3162: URL: https://github.com/apache/thrift/pull/3162#issuecomment-2947019928
I would be really, really happy if we could manage to get back to better descriptiosn than "this fixes X". First, a description like that lacks even the most basic information, like for example what exactly is broken. Next, neither this nor the original patch come with any tests attached. That way we can make pull requests for the next three years, each one promising to fix something we don't even know whether it is broken due to the lack of a test case. I would really love to see a bit more leaning towards quality. Thank you (both). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@thrift.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
