paroga commented on PR #3162: URL: https://github.com/apache/thrift/pull/3162#issuecomment-2948216153
> First, a description like that lacks even the most basic information, like for example what exactly is broken. It's in the title: the BUILD on BIG ENDIAN is broken > Next, neither this nor the original patch come with any tests attached. How do you expect somebody to write a test for a BUILD problem?!? (and even on a platform that's not running in the CI) PS: I'm not a regular contributor to this project. When i do a contribution to a project I usually check out a bunch of commit message to see what's the common style and try to fit into it. Expecting me to use a different style feels like a bad joke (and gatekeeping) to me. I get the wish for nice commit message, but don't expect that non-regular committers do it better than the regular ones, when there is also no explicit style written down in [`CONTRIBUTING.md`](https://github.com/apache/thrift/blob/81fb1a7968e9e65fb2288c6d5f84fe5410c21426/CONTRIBUTING.md). I just tired to [upstream the required patch](https://gitlab.alpinelinux.org/alpine/aports/-/commit/5be805c77bf9329fea112ab1a69c187bd936df3e) to get the latest version into Alpine Linux, because it's broken on [s390x](https://gitlab.alpinelinux.org/alpine/aports/-/jobs/1884801). Since I fixed it there already I get nothing out of this there. Feel free to take it as it is and do whatever you like to do with it, but don't expec t me to fix "commit message problems" of this project and write tests for build(!) failures. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@thrift.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
