CJCombrink commented on code in PR #3164:
URL: https://github.com/apache/thrift/pull/3164#discussion_r2131618892


##########
.github/workflows/build.yml:
##########
@@ -577,14 +644,17 @@ jobs:
       - uses: actions/setup-java@v4
         with:
           distribution: temurin
-          # here we intentionally use an older version so that we also verify 
Java 17 compiles to it

Review Comment:
   Is this comment actually true?
   I know Java compiled on an old version should work with newer versions: This 
is not the first time I run into the issue with a old version trying something 
compiled with a new version.
   The logs print this:
   > Exception in thread "main" java.lang.UnsupportedClassVersionError: 
org/apache/thrift/test/TestClientKt has been compiled by a more recent version 
of the Java Runtime (class file version 61.0), this version of the Java Runtime 
only recognizes class file versions up to 52.0
   
   Which proves the statement wrong



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@thrift.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to