CJCombrink commented on code in PR #3164:
URL: https://github.com/apache/thrift/pull/3164#discussion_r2136915830
##########
.github/workflows/build.yml:
##########
@@ -552,20 +553,86 @@ jobs:
- name: Run ts tests
run: make -C lib/nodets check
+ lib-cpp:
+ needs: compiler
+ runs-on: ubuntu-24.04
+ steps:
+ - uses: actions/checkout@v4
+
+ - name: Install dependencies
+ run: |
+ sudo apt-get update -yq
+ sudo apt-get install -y --no-install-recommends g++ $BUILD_DEPS
locales
+ sudo locale-gen en_US.UTF-8
+ sudo locale-gen de_DE.UTF-8
Review Comment:
There is a test in ToStringTest.cpp that is part of the lib tests that
requires this, else the tests fails.
See
[ToStringTest.cpp#L57](https://github.com/apache/thrift/blob/master/lib/cpp/test/ToStringTest.cpp#L57)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@thrift.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
