Jens-G commented on code in PR #3164:
URL: https://github.com/apache/thrift/pull/3164#discussion_r2143639652
##########
lib/cpp/src/thrift/protocol/THeaderProtocol.cpp:
##########
@@ -146,6 +146,10 @@ uint32_t THeaderProtocol::writeBinary(const std::string&
str) {
return proto_->writeBinary(str);
}
+uint32_t THeaderProtocol::writeUUID(const TUuid& uuid) {
Review Comment:
> Can I just create a Jira Ticket for it and we close it part of this PR
I think either way is fine.
##########
lib/cpp/src/thrift/protocol/THeaderProtocol.cpp:
##########
@@ -146,6 +146,10 @@ uint32_t THeaderProtocol::writeBinary(const std::string&
str) {
return proto_->writeBinary(str);
}
+uint32_t THeaderProtocol::writeUUID(const TUuid& uuid) {
Review Comment:
> Can I just create a Jira Ticket for it and we close it part of this PR
I think either way is fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@thrift.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
