CJCombrink commented on code in PR #3164:
URL: https://github.com/apache/thrift/pull/3164#discussion_r2142395247


##########
lib/cpp/src/thrift/protocol/TProtocolTap.h:
##########
@@ -166,6 +166,12 @@ class TProtocolTap : public TVirtualProtocol<TProtocolTap> 
{
     return rv;
   }
 
+  uint32_t readUUID(TUuid& uuid) {

Review Comment:
   I just saw this as missing, I will see if it makes sense to add a test for 
this protocol since I see there aren't any



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@thrift.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to