CJCombrink commented on code in PR #3170:
URL: https://github.com/apache/thrift/pull/3170#discussion_r2160972060


##########
go.mod:
##########
@@ -1,3 +1,4 @@
 module github.com/apache/thrift
 
 go 1.23

Review Comment:
   I have not much experience with go but during my hackings (unrelated) found 
that if I set this version to 1.23.0 I get a valid makefile (See this commit: 
https://github.com/apache/thrift/pull/3144/commits/5d2d4adaea237b118ea8ef01bea0741635826941)
 
   If your change is the correct one then thanks :) 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@thrift.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to