zheguang commented on PR #3170: URL: https://github.com/apache/thrift/pull/3170#issuecomment-2998353703
Thanks for reviewing, @fishy! To your point though, having `toolchain` line (or release version `1.23.R` within the `go` line) will accomplish what we need here, which is the minimum required version to compile the module: Older version will need to go through language compatibility check by Go, and if compatible, auto switch to the minimum release version [3]. For this auto-switching to work though, we'll need specify not just the language version `1.23` but also the release version `1.23.R`. One sticky point is whether we want this auto-switching... Here is what I see: 1. Without auto-switching, we need to document the minimum version requirement in text 2. Or with auto-switching, we codify the minimum version, and let Go check for compatibility I think (2) seems better. Plan B - if we don't want to go as far as auto-switching as in (1), one idea is to improve the makefile generation to catch somewhat cryptic the toolchain-not-found error, and suggest a hard upgrade, rather than chucking up a garbled makefile: https://github.com/apache/thrift/blob/67f828012710d05495ec240467c3750f99ddfe27/configure.ac#L380 Feel free to let me know which way we prefer. References: 3. https://go.dev/blog/toolchain -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@thrift.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
