Jens-G commented on code in PR #3529:
URL: https://github.com/apache/thrift/pull/3529#discussion_r3365988110
##########
compiler/cpp/src/thrift/generate/t_js_generator.cc:
##########
@@ -90,11 +94,27 @@ class t_js_generator : public t_oop_generator {
parse_imports(program, iter->second);
} else if (iter->first.compare("thrift_package_output_directory") == 0) {
parse_thrift_package_output_directory(iter->second);
+ } else if (iter->first.compare("bigint") == 0) {
+ if (iter->second.empty() || iter->second.compare("true") == 0) {
+ gen_bigint_ = true;
+ } else if (iter->second.compare("false") == 0) {
+ gen_bigint_ = false;
Review Comment:
I'm not sure why we need `bigint=true` and `bigint=false`? Wouldn't just
`bigint` be sufficient? Or maybe `use_bigint` or the like. Especially since
there is no third option at all and I also can't remember where else we did it
that way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
