jimexist commented on code in PR #3529:
URL: https://github.com/apache/thrift/pull/3529#discussion_r3366035899
##########
compiler/cpp/src/thrift/generate/t_js_generator.cc:
##########
@@ -90,11 +94,27 @@ class t_js_generator : public t_oop_generator {
parse_imports(program, iter->second);
} else if (iter->first.compare("thrift_package_output_directory") == 0) {
parse_thrift_package_output_directory(iter->second);
+ } else if (iter->first.compare("bigint") == 0) {
+ if (iter->second.empty() || iter->second.compare("true") == 0) {
+ gen_bigint_ = true;
+ } else if (iter->second.compare("false") == 0) {
+ gen_bigint_ = false;
Review Comment:
Good call — switched to a bare `bigint` flag in 4774ad020. Default flipped
to off (opt-in), so `--gen js:node` keeps emitting node-int64 `Int64` as
before; `--gen js:node,bigint` opts in to BigInt codegen. All Makefile /
testAll.sh invocations dropped the redundant `bigint=false` noise. This also
addresses your separate breaking-change concern: regenerated stubs are now
byte-compatible with existing consumers unless they explicitly pass `bigint`.
README and PR description updated to match.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
