dxbjavid commented on PR #3590: URL: https://github.com/apache/thrift/pull/3590#issuecomment-4677258309
good catch on the width, you're right that long and glong stay 32-bit under LLP64 so the product would still wrap on MSVC. i've switched the casts to int64_t in the c++ protocols and gint64 in the c_glib binary and compact readers, and widened the checkReadBytesAvailable parameter to match in both TTransport and the c_glib transport vtable, since otherwise the wider cast just gets truncated back through the glong parameter when the value is passed in. rechecked the binary list case and an oversized header is still rejected against a 1 KiB maxMessageSize after the change. on the second point, i've added the Client: cpp,c_glib trailer to the commit. i'll file a JIRA ticket for this and update the PR title and commit with the THRIFT- prefix once i have the number. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
