Jens-G commented on PR #3590:
URL: https://github.com/apache/thrift/pull/3590#issuecomment-4698173485
### Code review
Found 1 issue:
1. Both the PR body and the commit message describe the exploitation
mechanism ("a crafted list, set or map header can wrap the product down to a
small or zero value and slip past the maxMessageSize guard"). [AGENTS.md
ยง6](https://github.com/apache/thrift/blob/35c1a53dd6de205a4a7c23fc356f1fba490116c4/AGENTS.md#L87-L96)
says to use neutral functional language for serialization bounds changes and
to never describe what an attacker can achieve in public-facing text. A neutral
rewrite would be: "widen multiplication operands in container size prechecks to
prevent arithmetic overflow on LLP64 platforms."
https://github.com/apache/thrift/commit/41cb98af4d872f753b58c9663786156fa8636600
๐ค Generated with [Claude Code](https://claude.ai/code)
<sub>- If this code review was useful, please react with ๐. Otherwise, react
with ๐.</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
