kpumuk commented on code in PR #3627:
URL: https://github.com/apache/thrift/pull/3627#discussion_r3532092950
##########
lib/rb/spec/thin_http_server_spec.rb:
##########
@@ -20,9 +20,16 @@
require 'spec_helper'
require 'rack/test'
-require 'thrift/server/thin_http_server'
-describe Thrift::ThinHTTPServer do
+begin
+ require 'thrift/server/thin_http_server'
+rescue LoadError
+ # The thin gem is optional and may be excluded on unsupported Ruby versions.
+end
+
+thin_dependency = defined?(Thin) ? {} : { :skip => "thin not available" }
+
Review Comment:
If `Thin` is loaded, we do want to run the tests. I would rather see the
tests fail if `Thin` is defined, but the HTTP server is not, than silently skip
tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
