HTHou commented on PR #3820: URL: https://github.com/apache/thrift/pull/3820#issuecomment-5597822113
Thanks for updating the support matrix! Two entries still seem out of date: - **Java SE:** The tested versions should be **8 / 17**, rather than **11 / 19**. CI [builds with JDK 17](https://github.com/apache/thrift/blob/61ffe58f641e6fe6d576d23ec164e6296d9a01ad/.github/workflows/build.yml#L312-L316) and deliberately [runs cross-tests with Java 8](https://github.com/apache/thrift/blob/61ffe58f641e6fe6d576d23ec164e6296d9a01ad/.github/workflows/build.yml#L1227-L1232). The [Gradle configuration](https://github.com/apache/thrift/blob/61ffe58f641e6fe6d576d23ec164e6296d9a01ad/lib/java/gradle/sourceConfiguration.gradle#L32-L43) also uses a Java 17 toolchain with `options.release = 8`. These are the CI-tested bounds, rather than a maximum supported Java version. - **Rust TLS:** This should be marked as **supported**, with a note that it requires the optional `rustls` feature. [THRIFT-6097](https://github.com/apache/thrift/commit/cdb7e5fbe8d5bd7c3dd6dae779d39974f65577f9) already added both client and server TLS support, as documented in the [Rust README](https://github.com/apache/thrift/blob/61ffe58f641e6fe6d576d23ec164e6296d9a01ad/lib/rs/README.md#tls). Could these entries be updated as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
