HTHou commented on PR #3820: URL: https://github.com/apache/thrift/pull/3820#issuecomment-5597872521
With help from an AI tool, I checked the matrix against the source code and found a few more entries that appear to need updating: - **Rust — Domain sockets and ThreadPool:** Unix domain sockets are supported through [`listen_uds`](https://github.com/apache/thrift/blob/61ffe58/lib/rs/src/server/threaded.rs#L250), and [`TServer`](https://github.com/apache/thrift/blob/61ffe58/lib/rs/src/server/threaded.rs#L43) uses a fixed-size thread pool. Both entries should be marked as supported, with a Unix-platform note for domain sockets. - **Python — Memory and Framed transports:** Both [`TMemoryBuffer` and `TFramedTransport`](https://github.com/apache/thrift/blob/61ffe58/lib/py/src/transport/TTransport.py#L220) are implemented, but the matrix marks them as unsupported. - **Python — Threaded and ThreadPool servers:** Both [`TThreadedServer` and `TThreadPoolServer`](https://github.com/apache/thrift/blob/61ffe58/lib/py/src/server/TServer.py#L113) are implemented and should be marked as supported. - **Kotlin — Tested version:** The [Gradle plugin configuration](https://github.com/apache/thrift/blob/61ffe58/lib/kotlin/settings.gradle.kts#L19) uses **2.4.10**, while the new row lists **1.8**. - **Kotlin — Multiplex, zlib, Nonblocking and ThreadPool:** The cross-test server explicitly implements these options using the Java runtime. See the [zlib configuration](https://github.com/apache/thrift/blob/61ffe58/lib/kotlin/cross-test-server/src/main/kotlin/org/apache/thrift/test/TestServer.kt#L220) and [multiplex/server setup](https://github.com/apache/thrift/blob/61ffe58/lib/kotlin/cross-test-server/src/main/kotlin/org/apache/thrift/test/TestServer.kt#L258). - **Haxe — Memory transport:** `TMemoryStream` is available and has [round-trip tests](https://github.com/apache/thrift/blob/61ffe58/lib/haxe/test/src/tests/StreamTest.hx#L81), so Memory should be marked as supported. These observations are based on the source, build configuration and existing test code at the merge commit; I have not rerun the full cross-language test suite. Could these entries also be reviewed for a follow-up update? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
