slachiewicz opened a new pull request, #3937: URL: https://github.com/apache/thrift/pull/3937
`--gen st` wrote every enum twice: `init_generator` generated them and `t_generator::generate_program` generated them again. The loop in `init_generator` is gone. Verified: `--gen st` over every `.thrift` in the repository → 83 files change, each only by losing the duplicate enum blocks (the generator also stamps the run time). - [x] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? [THRIFT-6338](https://issues.apache.org/jira/browse/THRIFT-6338) - [x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"? - [x] Did you squash your changes to a single commit? - [x] Did you do your best to avoid breaking changes? No: the second definition replaced the first at load time. - [x] Code change, so the commit carries no CI-skip marker. - [x] Tests: `compiler/cpp/tests/st/t_st_generator_enum_tests.cc`, which fails without the fix; st generator tests are switched on. - [x] AI-assisted: the commit carries a `Co-Authored-By:` trailer. No new dependency or third-party code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
