Copilot commented on code in PR #3930:
URL: https://github.com/apache/thrift/pull/3930#discussion_r4108517452
##########
lib/netstd/Thrift/Transport/Client/THttpTransport.cs:
##########
@@ -32,15 +32,21 @@
namespace Thrift.Transport.Client
{
// ReSharper disable once InconsistentNaming
- public class THttpTransport : TEndpointTransport
+ public class THttpTransport : TEndpointTransport,
ITPerCallTransportProvider
Review Comment:
The current commit message contains `diffhunk://` footnote links. Repository
policy explicitly prohibits tool-internal links in commit messages or PR text
(`AGENTS.md:74-81`); remove those links from the squashed commit message before
merging.
##########
lib/netstd/Thrift/Transport/Client/THttpPerCallTransport.cs:
##########
@@ -0,0 +1,272 @@
+// Licensed to the Apache Software Foundation(ASF) under one
+// or more contributor license agreements.See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+using System;
+using System.IO;
+using System.Net.Http;
+using System.Threading;
+using System.Threading.Tasks;
+
+namespace Thrift.Transport.Client
+{
+ /// <summary>
+ /// Implementation of a per-call transport for THttpTransport.
+ /// Each call to the server will create a new HTTP request and response.
+ /// </summary>
+ internal class THttpPerCallTransport : TEndpointTransport
+ {
+ private readonly THttpTransport _parent;
+ private readonly MemoryStream _request = new MemoryStream();
+
+ private HttpResponseMessage _response;
+ private Stream _responseStream;
+ private CancellationTokenSource _responseReadTimeout;
+ private bool _sent;
+ private bool _disposed;
+
+ public THttpPerCallTransport(THttpTransport parent) :
base(parent.Configuration)
+ {
+ this._parent = parent;
+ }
+
+ public override bool IsOpen => !_disposed;
+
+ public override Task WriteAsync(
+ byte[] buffer,
+ int offset,
+ int length,
+ CancellationToken cancellationToken)
+ {
+ lock (_parent.LifecycleLock)
+ {
+ if (_disposed || !_parent.IsLifecycleOpen)
+ {
+ throw new
TTransportException(TTransportException.ExceptionType.NotOpen,
+ "The transport has been closed.");
+ }
+ if (_sent)
+ {
+ throw new InvalidOperationException("The request has
already been sent.");
+ }
+
+ return _request.WriteAsync(buffer, offset, length,
cancellationToken);
+ }
+ }
+
+ public override async Task FlushAsync(
+ CancellationToken cancellationToken)
+ {
+ lock (_parent.LifecycleLock)
+ {
+ if (_disposed || !_parent.IsLifecycleOpen)
+ {
+ throw new
TTransportException(TTransportException.ExceptionType.NotOpen,
+ "The transport has been closed.");
+ }
+ if (_sent)
+ {
+ throw new InvalidOperationException("The request has
already been sent.");
+ }
+
+ // Once a send is attempted the server may have processed the
RPC, even if
+ // response acquisition fails. Require a fresh per-call
transport to retry.
+ _sent = true;
+ _request.Position = 0;
+ }
+
+ var response = await _parent.SendAsync(_request,
cancellationToken);
+
+CancellationTokenSource responseReadTimeout = null;
+ Stream responseStream = null;
+ try
+ {
+ lock (_parent.LifecycleLock)
+ {
+ if (_disposed || !_parent.IsLifecycleOpen)
+ {
+ throw new
TTransportException(TTransportException.ExceptionType.NotOpen,
+ "The transport has been closed.");
+ }
+
+ var connectTimeout = _parent.ConnectTimeout;
+ responseReadTimeout = new CancellationTokenSource();
+ if (connectTimeout > 0)
+ {
+ responseReadTimeout.CancelAfter(connectTimeout);
+ }
Review Comment:
The per-call path likewise begins a new full `ConnectTimeout` after
`_parent.SendAsync` has already used the parent's `HttpClient.Timeout` while
waiting for headers. A slow server can therefore consume almost two timeout
periods, unlike the previous single deadline that covered the complete
response. Reuse an end-to-end deadline or compute the remaining interval before
creating the body-read timer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
