[
http://jira.xwiki.org/jira/browse/XWIKI-2006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_21090
]
Thomas Mortagne commented on XWIKI-2006:
----------------------------------------
Some comments about the patch
Vincent already said that but :
- you should not modify things that as nothing to do with the goal of your
patch like server->serverDatabase in XWiki.saveDocument)
- your code does not follow the xwiki coding rules to be applied (mainly
javadoc and some code style). See
http://dev.xwiki.org/xwiki/bin/view/Community/CodeStyle
Some more personal comments:
- I think you should separate theses two different features in two jira and
patches
- I don't see the need for staticParam(String key) and
staticGetMainDatabaseSchemaName()
- I think only HibernateStore should knows about main database name and prefix
database name, especially the way you implement it at wiki name -> database
name conversion. This means remove all you add to XWiki and call
context.getWiki().Param("xwiki.db") directly in getSchemaFromWikiName for
example.
- I think "xwiki.db" is not the best name for that parameter as it's only used
in virtual mode and it's the main wiki database name I would prefer something
like "xwiki.virtual.db.main". If this parameter means also the database name in
non virtual mode I doubt it works as context's database is not taken into
account in non virtual mode.
About your implementation of main wiki name, I would prefer to modify what
XWikiContext.getMainWiki returns which is here for that. We could remove derby
and hsqldb specifics conversions that would be useless if it can be setted in
xwiki.cfg. This means review the code to remove the remaining "xwiki" use as
main wiki in place of calling context.getMainXWiki().
> allows to configurate name of database schema [patch[
> -----------------------------------------------------
>
> Key: XWIKI-2006
> URL: http://jira.xwiki.org/jira/browse/XWIKI-2006
> Project: XWiki Platform
> Issue Type: New Feature
> Affects Versions: Future
> Environment: any
> Reporter: Ruslan Shevchenko
> Priority: Minor
> Attachments: configurated_db_schema_02.patch
>
>
> attached path allows to configure
> 1. name of database schema of main wiki.
> 2. prefixes for database schemas for virtual wikis.
> (tested by hand with normal and virtual wiki configurations)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.xwiki.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
_______________________________________________
notifications mailing list
[email protected]
http://lists.xwiki.org/mailman/listinfo/notifications
