[ 
https://issues.apache.org/jira/browse/YETUS-2?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14909589#comment-14909589
 ] 

Sean Busbey commented on YETUS-2:
---------------------------------

site looks nice.

nit: had to use --whitespace=fix when applying locally.

LICENSE needs to be updated for bundled works.

* bootstrap
** glyphicons needs to be noted as coming from bootstrap
* jquery
* font awesome

several files missing license header (looks like *.erb, *.md, Rakefile, and 
Gemfile)

asf-site-src/README.md has incorrect instructions on publishing (it's based on 
svnpubsub). looks like asf-site-src/source/contribute.html.md has the correct 
instructions

nit: why the Rakefile if we're not going to suggest using it in the 
instructions?

{code}
+### Development Setup
+We use middleman to generate the website content from markdown and other 
+dynamic templates. The following steps assume you have a working 
+ruby environment setup
+
+       gem install bundler
+       bundle install
+
{code}

what version(s) of ruby?  MRI Ruby 2.2.0 worked for me. Not sure if we want to 
specify. Jruby 1.7.3 and MRI Ruby 1.9.3 both failed, but those are notably old.

> Build website
> -------------
>
>                 Key: YETUS-2
>                 URL: https://issues.apache.org/jira/browse/YETUS-2
>             Project: Yetus
>          Issue Type: Improvement
>            Reporter: Sean Busbey
>            Priority: Critical
>         Attachments: YETUS-2.00.patch
>
>
> the gitpubsub set up only serves static content directly to browsers. We need 
> some means to build our markdown (or whatever) source into html, and a 
> workflow to push it into hte gitpubsub branch.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to