[ 
https://issues.apache.org/jira/browse/YETUS-116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14968476#comment-14968476
 ] 

Tony Kurc commented on YETUS-116:
---------------------------------

I contemplated just swapping the goal used by maven and using that flag and 
calling it "done". However, it did concern me that it depended on the 
checkstyle:check parameters being a superset of checkstyle:checkstyle. It does 
not appear to be the case.

A diff of the parameters they support (from [1] and [2])
{noformat}
tkurc@computer:~$ diff -y checkstyle.txt check.txt 
includeResources                                                includeResources
includeTestResources                                            
includeTestResources
includes                                                        includes
resourceIncludes                                                resourceIncludes
cacheFile                                                       cacheFile
                                                              > checkstyleRules
configLocation                                                  configLocation
consoleOutput                                                   consoleOutput
enableFilesSummary                                            <
enableRSS                                                     <
enableRulesSummary                                            <
enableSeveritySummary                                         <
encoding                                                        encoding
excludes                                                        excludes
                                                              > failOnViolation
failsOnError                                                    failsOnError
format                                                        <
headerFile                                                    <
headerLocation                                                  headerLocation
includeTestSourceDirectory                                      
includeTestSourceDirectory
linkXRef                                                      | 
logViolationsToConsole
                                                              > 
maxAllowedViolations
outputFile                                                      outputFile
outputFileFormat                                                outputFileFormat
packageNamesFile                                              <
packageNamesLocation                                          <
propertiesFile                                                <
propertiesLocation                                              
propertiesLocation
propertiesURL                                                 <
propertyExpansion                                               
propertyExpansion
resourceExcludes                                                resourceExcludes
                                                              > rulesFiles
skip                                                            skip
                                                              > skipExec
sourceDirectories                                               
sourceDirectories
sourceDirectory                                                 sourceDirectory
suppressionsFile                                              <
suppressionsFileExpression                                      
suppressionsFileExpression
suppressionsLocation                                            
suppressionsLocation
testSourceDirectories                                           
testSourceDirectories
testSourceDirectory                                             
testSourceDirectory
treeWalkerNames                                               <
useFile                                                         useFile
xrefLocation                                                  | violationIgnore
                                                              > 
violationSeverity
{noformat}


[1] 
https://maven.apache.org/plugins/maven-checkstyle-plugin/checkstyle-mojo.html
[2] https://maven.apache.org/plugins/maven-checkstyle-plugin/check-mojo.hml

> Investigate checkstyle:check goal for checkstyle plugin
> -------------------------------------------------------
>
>                 Key: YETUS-116
>                 URL: https://issues.apache.org/jira/browse/YETUS-116
>             Project: Yetus
>          Issue Type: Task
>          Components: Test Patch
>            Reporter: Tony Kurc
>            Assignee: Tony Kurc
>            Priority: Minor
>
> From a discussion on the dev mailing list 
> (https://mail-archives.apache.org/mod_mbox/yetus-dev/201510.mbox/%3CCAN5cbe4Z%3DgKzX5XbmK1FE8aAt5d3fwN0Yi0N7WtP40rY2fqZBg%40mail.gmail.com%3E)
>  checkstyle:check goal may provide some benefits for the checkstyle plugin 
> over checkstyle:checkstyle. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to