[
https://issues.apache.org/jira/browse/YETUS-281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15135850#comment-15135850
]
Chris Nauroth commented on YETUS-281:
-------------------------------------
[~aw], good catch! I guess that means the following block of code wasn't
working the way I think it works?
{code}
# For modules which are not in ordered list,
# add them at last
for module in $( echo "${passed_modules}" | tr ' ' '\n'); do
# shellcheck disable=SC2086
if ! hadoop_check_module_present "${module}" ${ordered_modules}; then
yetus_debug "Personality ordering ${module}"
ordered_modules="${ordered_modules} ${module}"
fi
done
{code}
That code looks correct to me. Do you know why it wasn't working?
Have you had a chance to test this on any Hadoop patches, like maybe something
that touches hadoop-yarn-server-timeline-pluginstorage or hadoop-hdfs-httpfs?
(The latter was misspelled, so I assume it also wasn't getting tested.)
{code}
hadoop-hdfs-project/hadoop-hdfs-httfs
{code}
> hadoop: use built-in dependency order
> -------------------------------------
>
> Key: YETUS-281
> URL: https://issues.apache.org/jira/browse/YETUS-281
> Project: Yetus
> Issue Type: Improvement
> Components: Test Patch
> Reporter: Allen Wittenauer
> Assignee: Allen Wittenauer
> Priority: Blocker
> Attachments: YETUS-281.00.patch
>
>
> With the commit of YETUS-280, hadoop should loosen the reins a bit and drop
> several hundred lines of code to use the built-in dependency creator.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
