[ 
https://issues.apache.org/jira/browse/YETUS-281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138092#comment-15138092
 ] 

Allen Wittenauer commented on YETUS-281:
----------------------------------------

Thanks for the review. :)

bq. Is this limitation only because our findbugs.sh is coded to iterate through 
the individual modules, or is there some deeper limitation? Could findbugs.sh 
be enhanced to traverse a "union'd" build and find the individual findbugs 
reports?

It's a little bit of both. Running mvn findbugs:findbugs seems to be hit or 
miss on when/where it generates output.  But findbugs.sh doesn't know it needs 
to traverse either.

bq. I'm in favor of more use of union'ing wherever possible for performance, 
but I also see that as less urgent than the current bug fix patch.

Yeah, it's a hard line to walk sometimes, especially when one is looking at the 
execution times for things.  e.g, doing a union in yarn is pretty horrific if 
you don't need yarn-resource-manager actually tested. :/

> hadoop: use built-in dependency order
> -------------------------------------
>
>                 Key: YETUS-281
>                 URL: https://issues.apache.org/jira/browse/YETUS-281
>             Project: Yetus
>          Issue Type: Improvement
>          Components: Test Patch
>            Reporter: Allen Wittenauer
>            Assignee: Allen Wittenauer
>            Priority: Blocker
>         Attachments: YETUS-281.00.patch, YETUS-281.02.patch
>
>
> With the commit of YETUS-280, hadoop should loosen the reins a bit and drop 
> several hundred lines of code to use the built-in dependency creator.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to