[ 
https://issues.apache.org/jira/browse/YETUS-499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973997#comment-15973997
 ] 

Casey Brotherton commented on YETUS-499:
----------------------------------------

I amended the awk statement in github_jira_bridge to also check for 
*pull/[0-9]+

It recognized the pull request in YETUS-315 and tried to pull the patch file 
correctly


> github pull requests not ending in patch are not found in Jira bug systems
> --------------------------------------------------------------------------
>
>                 Key: YETUS-499
>                 URL: https://issues.apache.org/jira/browse/YETUS-499
>             Project: Yetus
>          Issue Type: Bug
>            Reporter: Casey Brotherton
>            Assignee: Casey Brotherton
>         Attachments: YETUS-499.00.patch
>
>
> For example:
> YETUS-315 contains a pull request not ending in a patch.
> Performing:
> {code}
> ./precommit/test-patch.sh --plugins=all YETUS-315 
> {code}
> determines correctly that YETUS-315 isn't a pull request, 
> correctly contacts the Jira system, downloads the Jira text, and
> then looks for a file starting in GITHUB_BASE_URL and ending in "patch"
> this is not found, because the link attached is a pull link ending with a 
> number.
> This could be improved.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to