[
https://issues.apache.org/jira/browse/YETUS-499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014766#comment-16014766
]
Allen Wittenauer commented on YETUS-499:
----------------------------------------
It comes down to which cases one wants to write code for:
* opened incorrectly; manual fix on the user side
* parsing every comment that mentions a pull # to see if it is this JIRA or
another one
* parsing every comment that mentions a pull # to see if it is actually
referencing a change to the patch
Handling the last two is a significant amount more work and is going to require
a lot more than just an awk string change. The .patch requirement prevents the
oddball situation where someone links multiple github PRs in the same issue
because (as demonstrated here) most people will not link to the patch. (and
yes, there are definitely cases out there where multiple PRs have been linked
to in the same issue...)
> github pull requests not ending in patch are not found in Jira bug systems
> --------------------------------------------------------------------------
>
> Key: YETUS-499
> URL: https://issues.apache.org/jira/browse/YETUS-499
> Project: Yetus
> Issue Type: Bug
> Reporter: Casey Brotherton
> Assignee: Casey Brotherton
> Priority: Minor
> Attachments: YETUS-499.00.patch, YETUS-499.01.patch
>
>
> For example:
> YETUS-315 contains a pull request not ending in a patch.
> Performing:
> {code}
> ./precommit/test-patch.sh --plugins=all YETUS-315
> {code}
> determines correctly that YETUS-315 isn't a pull request,
> correctly contacts the Jira system, downloads the Jira text, and
> then looks for a file starting in GITHUB_BASE_URL and ending in "patch"
> this is not found, because the link attached is a pull link ending with a
> number.
> This could be improved.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
