[
https://issues.apache.org/jira/browse/YETUS-506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16010951#comment-16010951
]
Yetus QA commented on YETUS-506:
--------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 43m
13s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} shellcheck {color} | {color:red} 0m
0s{color} | {color:red} The patch generated 1 new + 1 unchanged - 0 fixed = 2
total (was 1) {color} |
| {color:green}+1{color} | {color:green} shelldocs {color} | {color:green} 0m
0s{color} | {color:green} There were no new shelldocs issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
0s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 43m 20s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.11.2 Server=1.11.2 Image:yetus/yetus:e4e4903 |
| JIRA Issue | YETUS-506 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12868106/YETUS-506.01.patch |
| Optional Tests | shellcheck shelldocs |
| uname | Linux 4178f25d1259 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31
14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | nobuild |
| git revision | master / 2971eff |
| shellcheck | v0.4.6 |
| shellcheck |
https://builds.apache.org/job/PreCommit-YETUS-Build/557/artifact/patchprocess/diff-patch-shellcheck.txt
|
| modules | C: . U: . |
| Console output |
https://builds.apache.org/job/PreCommit-YETUS-Build/557/console |
| Powered by | Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> Enhance maven_reorder_module_process to handle modules where directory name
> is different than the artifactId
> ------------------------------------------------------------------------------------------------------------
>
> Key: YETUS-506
> URL: https://issues.apache.org/jira/browse/YETUS-506
> Project: Yetus
> Issue Type: Improvement
> Reporter: Peter Vary
> Assignee: Peter Vary
> Attachments: YETUS-506.00.patch, YETUS-506.01.patch
>
>
> The Hive source looks like this:
> {code}
> hive
> |-common
> \-ql
> {code}
> The module hierarchy is this:
> {code}
> hive
> |-hive-common
> \-hive-exec
> {code}
> As a result of this differences, the {{maven_reorder_module_process}} unable
> to identify these modules, and does not reorder them.
> Also the current code expects that every artifact_id is different which
> might be, or might not be a problem.
> It would be much cleaner if we check the actual folder names instead which we
> can get by the following command:
> {code}
> mvn -q --also-make exec:exec -Dexec.executable=pwd
> {code}
> [~busbey], [~sekikn]: Do you think it would be good to include this in the
> Yetus head, or should I keep this change in Hive?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
