[
https://issues.apache.org/jira/browse/YETUS-506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16012962#comment-16012962
]
Allen Wittenauer commented on YETUS-506:
----------------------------------------
After playing with this for a bit, in general, I'm still sort of concerned
about the time increase. But we probably need some 'real world' experience to
see how off-putting it is. That said, some general comments:
{code}
Determining Maven Dependency Order
{code}
I think this message and related should get modified so that it also mentions
it is downloading dependencies. That will help offset any "why is this taking
so long" questions. Prior, it was implied with the mvn install since that's
exactly what you'd expect. It'd also be nice to have an elapsed timer on
screen.
{code}
# this *should* be pretty darn close to the correct order
{code}
Nope, with this patch, this *is* the order.
Other than that, it appears to be working on the (albeit limited) testing I've
done.
> Enhance maven_reorder_module_process to handle modules where directory name
> is different than the artifactId
> ------------------------------------------------------------------------------------------------------------
>
> Key: YETUS-506
> URL: https://issues.apache.org/jira/browse/YETUS-506
> Project: Yetus
> Issue Type: Improvement
> Reporter: Peter Vary
> Assignee: Peter Vary
> Attachments: YETUS-506.00.patch, YETUS-506.01.patch,
> YETUS-506.02.patch
>
>
> The Hive source looks like this:
> {code}
> hive
> |-common
> \-ql
> {code}
> The module hierarchy is this:
> {code}
> hive
> |-hive-common
> \-hive-exec
> {code}
> As a result of this differences, the {{maven_reorder_module_process}} unable
> to identify these modules, and does not reorder them.
> Also the current code expects that every artifact_id is different which
> might be, or might not be a problem.
> It would be much cleaner if we check the actual folder names instead which we
> can get by the following command:
> {code}
> mvn -q --also-make exec:exec -Dexec.executable=pwd
> {code}
> [~busbey], [~sekikn]: Do you think it would be good to include this in the
> Yetus head, or should I keep this change in Hive?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
