[ 
https://issues.apache.org/jira/browse/YETUS-499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014791#comment-16014791
 ] 

Akira Ajisaka commented on YETUS-499:
-------------------------------------

bq. The .patch requirement prevents the oddball situation where someone links 
multiple github PRs in the same issue because (as demonstrated here) most 
people will not link to the patch.
Agreed.

bq. opened incorrectly; manual fix on the user side
Agreed, but I'm thinking it's difficult for user/developer to find the 
workaround (add .patch link). Is there a better way to handle such situation? 
Anyway, I'll document this workaround in Hadoop wiki.

> github pull requests not ending in patch are not found in Jira bug systems
> --------------------------------------------------------------------------
>
>                 Key: YETUS-499
>                 URL: https://issues.apache.org/jira/browse/YETUS-499
>             Project: Yetus
>          Issue Type: Bug
>            Reporter: Casey Brotherton
>            Assignee: Casey Brotherton
>            Priority: Minor
>         Attachments: YETUS-499.00.patch, YETUS-499.01.patch
>
>
> For example:
> YETUS-315 contains a pull request not ending in a patch.
> Performing:
> {code}
> ./precommit/test-patch.sh --plugins=all YETUS-315 
> {code}
> determines correctly that YETUS-315 isn't a pull request, 
> correctly contacts the Jira system, downloads the Jira text, and
> then looks for a file starting in GITHUB_BASE_URL and ending in "patch"
> this is not found, because the link attached is a pull link ending with a 
> number.
> This could be improved.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to