[ 
https://issues.apache.org/jira/browse/YETUS-543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16162197#comment-16162197
 ] 

Andrew Wang commented on YETUS-543:
-----------------------------------

I'll embarrass myself and admit that I've never run test-patch locally. How 
should I test this to make sure it works?

Looking at the code itself, only some nit questions:

* do we need shelldoc on the _clean and _init functions?
* yetus_debug statements, should we prefix the message with the function or 
personality name? Other invocations do this.
* What's the reason for -Dtest=NoSuchTest rather than -DskipTests? It looks 
like the failsafe plugin supports skipTests too.

> Add shaded client related ITs to Hadoop exemplar personality
> ------------------------------------------------------------
>
>                 Key: YETUS-543
>                 URL: https://issues.apache.org/jira/browse/YETUS-543
>             Project: Yetus
>          Issue Type: Improvement
>          Components: Test Patch
>            Reporter: Sean Busbey
>            Assignee: Sean Busbey
>         Attachments: YETUS-543.0.patch
>
>
> see HADOOP-13917 for details



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to