[
https://issues.apache.org/jira/browse/YETUS-15?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16670229#comment-16670229
]
Allen Wittenauer edited comment on YETUS-15 at 10/31/18 3:20 PM:
-----------------------------------------------------------------
Thanks!
bq. but is "the same command" or something better than "the same build helper
script"
Yes, it is. I missed that. :(
bq. I newly noticed that the root directory of the source distribution is set
to 'archive', not 'apache-yetus-${version}-src'.
Argh. I thought I fixed that a while back. Anyway, I think that fails one of
[~busbey]'s criteria for commit if I interpret his comments in here correctly.
bq. Yetus' pom doesn't have "apache-release" profile
The apache-release profile comes from the parent Apache pom... which should
probably be bumped up to 21 (18 was current when I started on this change). See
https://maven.apache.org/pom/asf/ . This patch doesn't really take advantage
of it much and probably something else that should get refined at some point.
EDIT: It looks like the recent apache pom changes have updated quite a bit to
be relatively modern and up-to-date for what I needed to make things work in
this patch. It might be worthwhile to do that update now and actually remove
quite a bit of versioning from our local one.
was (Author: aw):
Thanks!
bq. but is "the same command" or something better than "the same build helper
script"
Yes, it is. I missed that. :(
bq. I newly noticed that the root directory of the source distribution is set
to 'archive', not 'apache-yetus-${version}-src'.
Argh. I thought I fixed that a while back. Anyway, I think that fails one of
[~busbey]'s criteria for commit if I interpret his comments in here correctly.
bq. Yetus' pom doesn't have "apache-release" profile
The apache-release profile comes from the parent Apache pom... which should
probably be bumped up to 21 (18 was current when I started on this change). See
https://maven.apache.org/pom/asf/ . This patch doesn't really take advantage
of it much and probably something else that should get refined at some point.
> build environment
> -----------------
>
> Key: YETUS-15
> URL: https://issues.apache.org/jira/browse/YETUS-15
> Project: Yetus
> Issue Type: Improvement
> Components: Test Patch
> Affects Versions: 0.1.0
> Reporter: Allen Wittenauer
> Assignee: Allen Wittenauer
> Priority: Critical
> Fix For: 0.9.0
>
> Attachments: HADOOP-12137.HADOOP-12111.00.patch,
> HADOOP-12137.HADOOP-12111.01.patch, YETUS-15.000.patch, YETUS-15.002.patch,
> YETUS-15.004.patch, YETUS-15.005.patch, YETUS-15.006.patch,
> YETUS-15.007.patch, YETUS-15.008.patch, YETUS-15.009.patch,
> YETUS-15.010.patch, YETUS-15.03.patch, YETUS-15.ea-maven-001.patch
>
>
> We need to have some way to build (esp the documentation!) and unit tests.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
