lvfangmin commented on a change in pull request #959: ZOOKEEPER-3402: Add
multiRead operation
URL: https://github.com/apache/zookeeper/pull/959#discussion_r290947506
##########
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/MultiTransactionRecord.java
##########
@@ -28,20 +28,25 @@
import java.util.List;
/**
- * Encodes a composite transaction. In the wire format, each transaction
+ * Encodes a composite operation. In the wire format, each operation
* consists of a single MultiHeader followed by the appropriate request.
* Each of these MultiHeaders has a type which indicates
- * the type of the following transaction or a negative number if no more
transactions
+ * the type of the following operation or a negative number if no more
operations
* are included.
+ * All of the operations must be from the same OpKind.
+ * Note: This class is called MultiTransactionRecord because of legacy reasons,
+ * MultiOperationRecord would be more accurate.
*/
public class MultiTransactionRecord implements Record, Iterable<Op> {
Review comment:
Should we create a new MultiReadRecord instead of reusing this one? Since
the read is not txn, and we don't allow read mixed with write.
It avoided some unnecessary check in the code, and also less confusing to
user.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
