lvfangmin commented on a change in pull request #959: ZOOKEEPER-3402: Add
multiRead operation
URL: https://github.com/apache/zookeeper/pull/959#discussion_r290948493
##########
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/FinalRequestProcessor.java
##########
@@ -574,6 +585,41 @@ public void processRequest(Request request) {
}
}
+ private Record handleReadRequest(int opCode, Record request, ServerCnxn
cnxn, List<Id> authInfo)
+ throws KeeperException, IOException {
+ switch(opCode) {
+ case OpCode.getChildren: {
+ GetChildrenRequest getChildrenRequest = (GetChildrenRequest)
request;
Review comment:
Please refactor the code to reuse existing logic for getChildren and
getData, which makes it easier to maintain in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
