ztzg opened a new pull request #1054: ZOOKEEPER-1112: Add support for C client for SASL authentication URL: https://github.com/apache/zookeeper/pull/1054 This is a forward-port of Tom Klonikowski's (@kloni) [ZOOKEEPER-1112](https://issues.apache.org/jira/browse/ZOOKEEPER-1112) patches on top of the current `master` branch. It stays close to the original patches, and only adds two commits on top: 1. A simple way to pass passwords to the console client via files; 2. A fix for an use-after-free in the C client library. Open questions: 1. The patches add an optional dependency on the Cyrus SASL library. [Eric Yang wrote](https://issues.apache.org/jira/browse/ZOOKEEPER-1112?focusedCommentId=13080468&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-13080468): > Apache Web Server has a module for authenticate sasl using Cyrus SASL library. I think the license should be compatible with written agreement from CMU. Who should take care of this? Is there an established procedure? 2. [Tom Klonikowski wrote](https://issues.apache.org/jira/browse/ZOOKEEPER-1112?focusedCommentId=13126379&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-13126379): > Maybe part #2 (sasl auth implementation via cyrus sasl) and #3 (cli using #2) should be moved to the recipes section (recipes/sasl). What do you think? What do you think? The existing tests as well as the added SASL tests pass in `st` and `mt` modes. Both `cli_sasl_*` utilities have been tested against a `DIGEST-MD5` server; I intend to test them against a GSSAPI one in the near future.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
