hanm commented on a change in pull request #1049: ZOOKEEPER-3475 Enable
Checkstyle configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#discussion_r313032932
##########
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NIOServerCnxnFactory.java
##########
@@ -962,14 +979,14 @@ public void dumpConnections(PrintWriter pwriter) {
@Override
public void resetAllConnectionStats() {
// No need to synchronize since cnxns is backed by a ConcurrentHashMap
- for(ServerCnxn c : cnxns){
+ for (ServerCnxn c : cnxns) {
c.resetStats();
}
}
@Override
public Iterable<Map<String, Object>> getAllConnectionInfo(boolean brief) {
- HashSet<Map<String,Object>> info = new HashSet<Map<String,Object>>();
+ HashSet<Map<String, Object>> info = new HashSet<Map<String, Object>>();
Review comment:
I'd also prefer limiting the scope of this change to be mechanical changes
that's only appertain to style and formatting.
@TisonKun since you are on this, do you mind to create a couple of JIRAs to
follow up the issues around log formatting, interface declaration and other
nits that @enixon pointed out?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
