enixon commented on a change in pull request #1100: ZOOKEEPER-3509: Revisit log
format
URL: https://github.com/apache/zookeeper/pull/1100#discussion_r329701474
##########
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Learner.java
##########
@@ -505,7 +516,10 @@ protected void syncWithLeader(long newLeaderZxid) throws
Exception {
}
if (!writeToTxnLog) {
if (pif.hdr.getZxid() != qp.getZxid()) {
- LOG.warn("Committing " + qp.getZxid() + ", but
next proposal is " + pif.hdr.getZxid());
+ LOG.warn(
+ "Committing {}, but next proposal is {}",
Review comment:
Add "0x"s?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
