enixon commented on a change in pull request #1100: ZOOKEEPER-3509: Revisit log
format
URL: https://github.com/apache/zookeeper/pull/1100#discussion_r329705056
##########
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/ZKDatabase.java
##########
@@ -373,15 +381,15 @@ public long calculateTxnLogSizeLimit() {
// If we cannot guarantee that this is strictly the starting txn
// after a given zxid, we should fail.
if ((itr.getHeader() != null) && (itr.getHeader().getZxid() >
startZxid)) {
- LOG.warn("Unable to find proposals from txnlog for zxid: " +
startZxid);
+ LOG.warn("Unable to find proposals from txnlog for zxid: {}",
startZxid);
Review comment:
Add "0x"s? (and Long.toHexString())
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
