hanm commented on a change in pull request #1172: ZOOKEEPER-3594: Ability to
skip proposing requests with error transactions
URL: https://github.com/apache/zookeeper/pull/1172#discussion_r360589635
##########
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/ObserverMaster.java
##########
@@ -412,6 +412,12 @@ synchronized void proposalCommitted(long zxid) {
sendPacket(pkt);
}
+ synchronized void proposalSkipped(QuorumPacket qp) {
Review comment:
Is it possible to reuse the existing `sendPacket `? The only difference is
`sendPacket ` also updates `lastProposedZxid ` with the packet zxid.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
