hanm commented on a change in pull request #1172: ZOOKEEPER-3594: Ability to
skip proposing requests with error transactions
URL: https://github.com/apache/zookeeper/pull/1172#discussion_r360527855
##########
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumZooKeeperServer.java
##########
@@ -215,4 +215,8 @@ public void dumpMonitorValues(BiConsumer<String, Object>
response) {
response.accept("peer_state", self.getDetailedPeerState());
}
+ public static boolean isSkipTxnAvailable(int learnerProtocolVersion) {
+ return true;
Review comment:
Are we sure that we always want to return true here as opposed to have a
system property control the return value? Also, `learnerProtocolVersion` is not
used.. is this intentional?
It would be also good to add a brief comment on what this does - it's not
very obvious to me in first glance.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
