eolivelli commented on a change in pull request #1233: ZOOKEEPER-3701 Split
brain on log disk full
URL: https://github.com/apache/zookeeper/pull/1233#discussion_r370082101
##########
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/persistence/FileSnap.java
##########
@@ -260,6 +260,8 @@ public synchronized void serialize(
Util.getZxidFromName(snapShot.getName(),
SNAPSHOT_FILE_PREFIX),
snapShot.lastModified() / 1000);
}
+ } else {
+ throw new IllegalStateException("FileSnap has already been
closed");
Review comment:
will existing code handle this RuntimeException properly ?
what about throwing a IOException ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
